Skip to content

fix: add recurringP2PTransferId to P2PTransfer - #385

Merged
tylerGroesbeckMx merged 1 commit into
masterfrom
tyler/GCU-1431
Aug 18, 2026
Merged

fix: add recurringP2PTransferId to P2PTransfer#385
tylerGroesbeckMx merged 1 commit into
masterfrom
tyler/GCU-1431

Conversation

@tylerGroesbeckMx

@tylerGroesbeckMx tylerGroesbeckMx commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Mobile core added recurring_p2p_transfer_id field to P2P Transfers and it needs to be added to path-model

path-model: https://github.com/mxenabled/path-mdx-model/blob/master/mdx-models/src/main/java/com/mx/path/model/mdx/model/p2p_transfer/P2PTransfer.java

spec: https://developer.mx.com/drafts/mdx/p2p_transfer/index.html#changes-rev-1-2025-10-22

Fixes # https://mxcom.atlassian.net/browse/GCU-1431

Public API Additions/Changes

P2PTransfer now has an additional field: recurringP2PTransferId

Downstream Consumer Impact

This is just adding a field to an existing model so it shouldn't have a large impact.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Project builds successfully
  • Asked Claude code to check project for any issues with field addition and none were found
  • Published local snapshot and tested serialization. Response is working as expected:
GET http://localhost:3009/globalcu/users/U-00u3la36x0bbNvPud1d7/p2p_transfers/6902253

HTTP/1.1 200 
Content-Type: application/vnd.mx.mdx.v6+json;charset=UTF-8
Content-Length: 111
Date: Fri, 14 Aug 2026 21:45:03 GMT

{
  "p2p_transfer": {
    "recurring_p2p_transfer_id": "6902253",
    "user_id": "U-00u3la36x0bbNvPud1d7"
  }
}

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@stevecl5

Copy link
Copy Markdown
Contributor

@tylerGroesbeckMx Please fill out the "How Has This Been Tested?" and "Checklist" sections in the MR template.

@tylerGroesbeckMx
tylerGroesbeckMx force-pushed the tyler/GCU-1431 branch 2 times, most recently from 8ddfc8a to df136dc Compare August 18, 2026 16:47
@tylerGroesbeckMx
tylerGroesbeckMx merged commit e7b46cf into master Aug 18, 2026
7 checks passed
@tylerGroesbeckMx
tylerGroesbeckMx deleted the tyler/GCU-1431 branch August 18, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants